Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/cachet] ingress use tls key #550

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

AlessandroLorenzi
Copy link
Contributor

@AlessandroLorenzi AlessandroLorenzi commented Nov 27, 2023

Description

Without this configuration cert-manager cannot correctly generate certificate.

I've copied from stable/hoppscotch the snippet

Checklist

[✔️] Title of the PR starts with chart name (e.g. [stable/mychartname])
[✔️] I have read the contribution instructions, bumped chart version and regenerated the docs

@AlessandroLorenzi AlessandroLorenzi requested a review from a team as a code owner November 27, 2023 16:45
@AlessandroLorenzi AlessandroLorenzi changed the title fix: cachet ingress use tls key [stable/cachet] ingress use tls key Nov 27, 2023
@AlessandroLorenzi AlessandroLorenzi force-pushed the master branch 2 times, most recently from bf43fd2 to 8bdf47c Compare November 27, 2023 16:50
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @AlessandroLorenzi 💜

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) November 28, 2023 09:45
auto-merge was automatically disabled November 28, 2023 10:53

Head branch was pushed to by a user without write access

@AlessandroLorenzi
Copy link
Contributor Author

@max-rocket-internet Wops, I've bumped appVersion instead of version into Chart.yaml, now should pass.

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) November 28, 2023 12:28
@max-rocket-internet max-rocket-internet merged commit 2532100 into deliveryhero:master Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants