[stable/kubecost-reports-exporter] add deadline and ttl second specs (#…

…567)
deliveryhero · Mar 12, 2024 · 6021f45 · 6021f45
1 parent 706f102
commit 6021f45
Show file tree

Hide file tree

Showing 8 changed files with 44 additions and 3 deletions.
diff --git a/.github/workflows/check_pr.yaml b/.github/workflows/check_pr.yaml
@@ -0,0 +1,19 @@
+name: "PR Title Checker"
+on:
+  pull_request:
+    types:
+      - opened
+      - edited
+      - synchronize
+
+jobs:
+  check_pr_title:
+    name: check PR title
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v2
+      - uses: deepakputhraya/action-pr-title@master
+        with:
+          regex: '^\[stable\/+.+]\s.+'
+          prefix_case_sensitive: false
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -0,0 +1,8 @@
+repos:
+  - repo: https://github.com/norwoodj/helm-docs
+    rev: v1.11.0
+    hooks:
+      - id: helm-docs
+        args:
+          - --chart-search-root=stable
+          - --template-files=../ci/README.md.gotmpl
diff --git a/README.md b/README.md
@@ -80,6 +80,7 @@ This repository has multiple Github Actions to ensure quality is high, these inc
 
 - [chart-testing](https://github.com/helm/chart-testing): lint and install tests
 - [markdown-lint](https://github.com/avto-dev/markdown-lint): lint all markdown files
+- [pre-commit](https://pre-commit.com/): Auto generate helm docs before commit.
 - [helm-docs](https://github.com/norwoodj/helm-docs): check all chart `README.md` have all values documented
 - [helm-conftest](https://github.com/instrumenta/helm-conftest): Ensures standard labels are present
 
@@ -120,7 +121,13 @@ All commands to be run from the root of this repo.
   To generate chart `README.md` files from the [template](ci/README.md.gotmpl):
 
   ```console
+  <!-- docker -->
   docker run --rm -v "${PWD}:/helm-docs" jnorwood/helm-docs:v1.11.3 --template-files ./ci/README.md.gotmpl
+  <!-- pre-commit -->
+  # install pre-commit https://pre-commit.com/#install
+  $ brew install pre-commit
+  $  pre-commit install
+  $ pre-commit install-hooks
   ```
 
 `helm-conftest`:

diff --git a/stable/kubecost-reports-exporter/Chart.yaml b/stable/kubecost-reports-exporter/Chart.yaml
@@ -6,7 +6,7 @@ description: |
   if you are using old installation please use v1 chart
 home: https://www.kubecost.com
 type: application
-version: 2.0.3
+version: 2.0.4
 appVersion: "2.0.0"
 maintainers:
   - name: nyambati

diff --git a/stable/kubecost-reports-exporter/README.md b/stable/kubecost-reports-exporter/README.md
@@ -1,6 +1,6 @@
 # kubecost-reports-exporter
 
-![Version: 2.0.3](https://img.shields.io/badge/Version-2.0.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.0.0](https://img.shields.io/badge/AppVersion-2.0.0-informational?style=flat-square)
+![Version: 2.0.4](https://img.shields.io/badge/Version-2.0.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.0.0](https://img.shields.io/badge/AppVersion-2.0.0-informational?style=flat-square)
 
 Helm chart for exporting kubernetes cost reports to AWS s3 bucket.
 N/B We have updated chart to use V2 scripts using allocations and assets api.
@@ -48,6 +48,7 @@ helm install my-release deliveryhero/kubecost-reports-exporter -f values.yaml
 
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
+| activeDeadlineSeconds | int | `20` |  |
 | affinity | object | `{}` |  |
 | concurrencyPolicy | string | `"Forbid"` |  |
 | env | object | `{}` | Extra environment variables |
@@ -77,6 +78,7 @@ helm install my-release deliveryhero/kubecost-reports-exporter -f values.yaml
 | serviceAccount.name | string | `""` |  |
 | successfulJobsHistoryLimit | int | `1` |  |
 | tolerations | list | `[]` |  |
+| ttlSecondsAfterFinished | int | `0` |  |
 
 ## Maintainers
 

diff --git a/stable/kubecost-reports-exporter/docker/requirements.txt b/stable/kubecost-reports-exporter/docker/requirements.txt
@@ -1,4 +1,4 @@
 boto3>=0.17.0
-sentry-sdk==1.3.1
+sentry-sdk==1.14.0
 datadog-api-client>=2.0.0
 requests
diff --git a/stable/kubecost-reports-exporter/templates/allocation-assets-reports.yaml b/stable/kubecost-reports-exporter/templates/allocation-assets-reports.yaml
@@ -15,8 +15,11 @@ spec:
   successfulJobsHistoryLimit: {{ $.Values.successfulJobsHistoryLimit }}
   failedJobsHistoryLimit: {{ $.Values.failedJobsHistoryLimit }}
   concurrencyPolicy: {{ $.Values.concurrencyPolicy }}
+
   jobTemplate:
     spec:
+      activeDeadlineSeconds: {{ $.Values.activeDeadlineSeconds }}
+      ttlSecondsAfterFinished: {{ $.Values.ttlSecondsAfterFinished }}
       template:
         metadata:
           {{- with $.Values.podAnnotations }}

diff --git a/stable/kubecost-reports-exporter/values.yaml b/stable/kubecost-reports-exporter/values.yaml
@@ -7,6 +7,8 @@ restartPolicy: OnFailure
 successfulJobsHistoryLimit: 1
 failedJobsHistoryLimit: 1
 concurrencyPolicy: Forbid
+activeDeadlineSeconds: 20
+ttlSecondsAfterFinished: 0
 
 image:
   # image.repository -- The container image to use