Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc: 0012-changelog-specification.md #12
rfc: 0012-changelog-specification.md #12
Changes from 6 commits
b9442bc
11ec97d
e027844
e6b601a
bf5f1df
b2e06dc
d783d84
d0d1fbc
11e9ae3
19c2cf5
29dcf8a
4dadd40
38689e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为啥不定一个全局统一的版本号规范呢,这样的话不用判断那么多种情况了
我的建议如下
upstreamversion+deepin${ver1}[+dp26u${ver2}][+u${ver3}][+rb${ver4}]
ver1 来自deepin的patch版本,这块必须,且从0开始
ver2 安全补丁版本,这块只有发布安全补丁时需要
ver3 CI编译版本,这快只有CI编译时有
ver4 rebuild次数,这块只有rebuild时才添加
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
针对不用情况下使用不同的版本号规范,上述的很多情况都是少数情况下才会使用,开发者&审阅者需要判断当前软件包处理什么状态
其次这个规范本就是全局统一的, 只是分不同的情况分开讨论了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为我们要定主线/非主线
主线是没有安全补丁、CI编译的,只有rebuild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我这个是所有的都使用同一个格式, upstreamversion 后跟了四大块,[] 里的内容是非必须的,需要的时候添加,这样可以组合出文章里提到的全部情况
upstreamversion
+deepin${ver1}
[+dp26u${ver2}]
[+u${ver3}]
[+rb${ver4}]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我的意思是不同情况下格式不太一样,我上边的建议是统一的格式,需要的项目自由增删
upstreamversion
+deepin${ver1}
[+dp26u${ver2}]
[+u${ver3}]
[+rb${ver4}]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用 UTsweetyfish 提的方案3 也就不需要改这个了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kt286 @RevySR @UTsweetyfish 已更新 用UTsweetyfish提出的方案三解决 +dp23u1 < rb1 的问题 ,请各位及时review或提出其他问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BNF 已更新
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BNF已经加入正文中
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kt286 @RevySR @UTsweetyfish BNF已更新 请及时review 期望本周内能merge