[Deepin-Kernel-SIG] [Backport] [linux 6.6-y] wifi: rtl8xxxu: Fix RTL8188EU firmware upload block size

[opsiff]

mainline inclusion
from mainline-v6.14-rc1
category: bugfix

A user reports that the firmware upload consistently fails when it's uploaded in chunks of 128 bytes, but it works when uploaded in chunks of 196 bytes. The official driver uses 196 bytes also.

Link: a5a5aa555oo/rtl8xxxu#2

Link: https://patch.msgid.link/[email protected]
[gwt tips: rewrite path]

Summary by Sourcery

Bug Fixes:

• Fix firmware upload failure for RTL8188EU devices.

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request addresses a bug where the RTL8188EU firmware upload fails when using a block size of 128 bytes. The fix changes the firmware upload block size to 196 bytes, which is the value used by the official driver and resolves the reported issue.

Sequence diagram for RTL8188EU firmware upload process

sequenceDiagram
    participant Driver as RTL8188EU Driver
    participant Device as RTL8188EU Device
    Note over Driver, Device: Before fix: 128 byte blocks
    Driver->>Device: Upload firmware block (128 bytes)
    Device-->>Driver: Upload fails
    Note over Driver, Device: After fix: 196 byte blocks
    Driver->>Device: Upload firmware block (196 bytes)
    Device-->>Driver: Upload succeeds

Loading

Class diagram showing RTL8188EU driver structure modification

classDiagram
    class rtl8188eu_fops {
        +writeN_block_size: int
        +rx_desc_size: size_t
        +tx_desc_size: size_t
        +has_tx_report: int
        +set_crystal_cap()
        +cck_rssi()
        +led_classdev_brightness_set()
    }
    note for rtl8188eu_fops "Block size changed from 128 to 196 bytes"

Loading

File-Level Changes

Change	Details	Files
Changed the firmware upload block size for the RTL8188EU device.	Modified the writeN_block_size field in the rtl8188eu_fops structure from 128 to 196.	drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @opsiff - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment