[linux-6.6.y] Driver for Zhaoxin SM3 SM4 algorithms #272
Conversation
|
Hi @leoliu-oc. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
arch/x86/crypto/sm3_zhaoxin_gmi.c
Outdated
| if (gmi_available() == 0) | ||
| return crypto_register_shash(&zx_sm3_alg); | ||
|
|
||
| pr_warn("GMI is unavailable on this platform."); |
There was a problem hiding this comment.
这里应该是pr_info 不应该是pr_warn吧 所有x86都会走
There was a problem hiding this comment.
更新了一般，这里调整了逻辑。在匹配成功后才会pr_info打印。匹配不成功时不打印。这样就只有在兆芯平台才会有打印信息。
arch/x86/crypto/sm4_zhaoxin_gmi.c
Outdated
| pr_notice("GMI SM4 is detected by CPUID\n"); | ||
| return 0; | ||
| } | ||
| pr_notice("GMI SM4 is available\n"); |
There was a problem hiding this comment.
新版本中改为了pr_debug，供debug时判定用。正常情况下不输出log。
arch/x86/crypto/sm4_zhaoxin_gmi.c
Outdated
| if ((edx & 0x0030) != 0x0030) | ||
| return -ENODEV; | ||
|
|
||
| pr_notice("GMI SM4 is detected by CPUID\n"); |
arch/x86/crypto/sm3_zhaoxin_gmi.c
Outdated
| if ((edx & 0x0030) != 0x0030) | ||
| return -ENODEV; | ||
|
|
||
| pr_notice("GMI SM3 detected by CPUID\n"); |
arch/x86/crypto/sm3_zhaoxin_gmi.c
Outdated
| pr_notice("GMI SM3 detected by CPUID\n"); | ||
| return 0; | ||
| } | ||
| pr_notice("GMI SM3 is available\n"); |
leoliu-oc
force-pushed
the
linux-6.6.y-47-sm3-sm4
branch
from
0dd3699 to
7e843ed
Compare
zhaoxin inclusion category: feature CVE: NA ----------------- This SM3 algorithm driver is developed to support the SM3 instruction, making user develop their applications with both high performance and high security. Signed-off-by: leoliu-oc <[email protected]>
zhaoxin inclusion category: feature CVE: NA ----------------- This SM4 algorithm driver is developed to support the SM4 instruction, making user develop their applications with both high performance and high security. Signed-off-by: leoliu-oc <[email protected]>
leoliu-oc
force-pushed
the
linux-6.6.y-47-sm3-sm4
branch
from
7e843ed to
1c3c56d
Compare
|
/lgtm |
|
/ok-to-test |
|
New changes are detected. LGTM label has been removed. |
deepin pr auto reviewAdd ZX-E and ZX-C+ support for SM4 git-svn-id: ffe668792ed300d6c2daa1f6eba2e0aa28d7ec6c@136214 91177308-0d34-0410-b5e6-96231b3b80d8 |
Includes:
This SM3 algorithm driver is developed to support the SM3 instruction,
making user develop their applications with both high performance and high
security.
This SM4 algorithm driver is developed to support the SM4 instruction,
making user develop their applications with both high performance and high
security.