Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(CI): ignore check yml file warning" #271

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Jun 13, 2024

Reverts #251

@opsiff opsiff merged commit 3de1ce9 into linux-6.6.y Jun 13, 2024
1 of 7 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • check-patches.yml文件中,access_token变量被添加,但未看到对应的${{ github.event.pull_request.head.sha }}环境变量被使用。
  • headers字典中的"Accept"键被移除,但未看到对应的解释或替代逻辑。
  • 代码中存在重复的comment_json字典构建代码,可以考虑将其提取为一个函数以提高代码的可读性和可维护性。
  • 缺少对requests.post请求的异常处理,可能会导致未捕获的异常。

是否建议立即修改:

@opsiff opsiff deleted the revert-251-linux-6.6.y branch June 13, 2024 10:33
@deepin-ci-robot deepin-ci-robot requested a review from myml June 13, 2024 10:34
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zeno-sole for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants