Implement From<String>
for Model
, Language
, and Redact
#86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add an option to convert strings to various enumerated query options infallibly using
From<String>
.Types of changes
Checklist
Further comments
A customer has requested this feature. It is not the default way to specify the options, because we want to encourage customers to do it in a type-safe manner using the enum where possible. To use this version, one can simply do:
(Normally, one would probably have a
String
to begin with, if it were coming from a runtime input value, so theString::from
call would not be needed. If it is being created directly in code, the existing enum should be used directly.