Streaming callbacks #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcdyer
approved these changes
Aug 16, 2024
bd-g
commented
Aug 22, 2024
| .file(PATH_TO_FILE, AUDIO_CHUNK_SIZE, FRAME_DELAY) | ||
| .await?; | ||
|
|
||
| println!("Deepgram Request ID: {}", results.request_id()); |
There was a problem hiding this comment.
See here - simple way to grab request ID from the TranscriptionStream
jcdyer
requested changes
Aug 22, 2024
| @@ -737,6 +759,10 @@ impl<'a> WebsocketHandle { | |||
| // eprintln!("<handle> receiving response: {resp:?}"); | |||
| resp | |||
| } | |||
|
|
|||
| pub fn request_id(&self) -> Uuid { | |||
There was a problem hiding this comment.
Add docs to this function, and please mention that the request ID is needed for support on issues that come up with a particular request.
src/lib.rs
Outdated
|
|
||
| /// A Deepgram API server response was not in the expected format. | ||
| #[error("The Deepgram API server response was not in the expected format: {0}")] | ||
| UnexpectedServerResponse(String), |
There was a problem hiding this comment.
Change this from String to anyhow::Error, which is more flexible, and allows us to provide better-structured errors. (Then at error construction time, you can use anyhow!("missing request request_id") and anyhow!("malformed request_id: {:?}", request_id))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allows specifying a callback for streaming requests. See docs.
Types of changes
Checklist
Further comments
Added a doc to the
callback_methodoption to clarify the option is only respected for pre-recorded requests. May be worth making a breaking change in the future and refusing to accept streaming requests that attempt to set this option?