Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support options debug #78

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Support options debug #78

merged 6 commits into from
Jul 26, 2024

Conversation

jcdyer
Copy link
Contributor

@jcdyer jcdyer commented Jul 24, 2024

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING.md doc
  • I have added tests and/or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jcdyer jcdyer force-pushed the support-options-debug branch from 24d7bbd to 8667267 Compare July 24, 2024 18:07
@@ -110,7 +129,7 @@ impl OptionsBuilder {
/// #
/// let options1 = Options::builder("New Key", ["member"])
/// .tag(["Tag 1"])
/// .tag(["Tag 2"])
/// .tag(vec!["Tag 2"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to document that this function can take different kinds of iterables.

@jcdyer jcdyer requested review from DamienDeepgram and bd-g July 26, 2024 13:03
Copy link
Contributor

@bd-g bd-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcdyer jcdyer force-pushed the support-options-debug branch from 8667267 to 45bc3fa Compare July 26, 2024 15:15
@jcdyer jcdyer changed the base branch from update-and-refactor to main July 26, 2024 15:15
@bd-g bd-g self-requested a review July 26, 2024 18:34
@jcdyer jcdyer merged commit 1bbfefa into main Jul 26, 2024
9 checks passed
@jcdyer jcdyer deleted the support-options-debug branch July 26, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants