Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featurize transcription modes #68

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Featurize transcription modes #68

merged 8 commits into from
Jul 3, 2024

Conversation

jcdyer
Copy link
Contributor

@jcdyer jcdyer commented Jul 3, 2024 •
edited
Loading

Proposed changes

Add feature flags for live and prerecorded ASR. This helps non-streaming users not have to import tungstenite. I'm open to not doing things this way. I'm thinking of also following up with a little more specificity about which tokio features to include for similar reasons.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING.md doc
  • I have added tests and/or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jcdyer jcdyer requested a review from andrewhalle July 3, 2024 16:06
andrewhalle
andrewhalle approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@andrewhalle andrewhalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear we had these feature flags already, they must have been removed at some point in the past

Cargo.toml Show resolved Hide resolved
@jcdyer
Copy link
Contributor Author

jcdyer commented Jul 3, 2024

Oops. This PR breaks the examples. (Found doing cargo test --no-default-features. I guess I'll need to annotate the required features for each one.

@jcdyer jcdyer force-pushed the featurize-transcription-modes branch from b8bb662 to 8b19d19 Compare July 3, 2024 17:56
@jcdyer
Copy link
Contributor Author

jcdyer commented Jul 3, 2024

Also updated CI to run check with no features and with each feature in isolation.

@jcdyer jcdyer merged commit 8f9b6f9 into expand-languages Jul 3, 2024
16 of 18 checks passed
jcdyer added a commit that referenced this pull request Jul 3, 2024
@jcdyer
Revert "Featurize transcription modes (#68)"
9388322 
This reverts commit 8f9b6f9.
@jcdyer jcdyer mentioned this pull request Jul 3, 2024
Closed
@jcdyer jcdyer deleted the featurize-transcription-modes branch July 3, 2024 20:16
@jcdyer jcdyer mentioned this pull request Jul 3, 2024
Merged
jcdyer added a commit that referenced this pull request Jul 8, 2024
@jcdyer
Reapply featurization merge (#72)
decda72 
* Deprecate tiers and add fully qualified models

* Add all currently supported languages to the Language enum

* Add changelog entry

* Add changelog entry

* fmt

* Fix minimal tokio version

* fmt

* Featurize transcription modes (#68)

Add feature flags for prerecorded and live transcription
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhalle andrewhalle andrewhalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcdyer @andrewhalle