Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add paragraphs query options #65

Closed
wants to merge 4 commits into from
Closed

feat: Add paragraphs query options #65

wants to merge 4 commits into from

Conversation

BadMask121
Copy link

@BadMask121 BadMask121 commented Jun 3, 2024 •
edited by jcdyer
Loading

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING.md doc
  • I have added tests and/or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jcdyer
Copy link
Contributor

jcdyer commented Jul 3, 2024

Hi @BadMask121! Thanks for your contribution. I'll add some docs to these methods, and get them out the door in our 0.5 release.

jcdyer
jcdyer requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@jcdyer jcdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Spoke too soon. Some tests are failing. See below.

src/transcription/prerecorded/options.rs
Comment on lines +27 to +29
filler_words: bool,
smart_format: bool,
paragraphs: Option<bool>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change filler_words and smart_format to Option<bool>, so they don't get serialized unless the user requests them?

@DamienDeepgram
Copy link
Contributor

This has been addressed in this PR: #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcdyer jcdyer jcdyer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BadMask121 @jcdyer @DamienDeepgram