-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the Search response for streaming requests #463
Conversation
WalkthroughThe provided changes introduce support for search-related functionality in the response data, allowing for the retrieval of search queries and associated hit information. The key changes include the addition of new data classes, Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant WebsocketResponse
participant Channel
participant Hit
participant Search
Client->>WebsocketResponse: Receive response
WebsocketResponse->>Channel: Create Channel object
Channel->>Search: Create Search object(s)
Search->>Hit: Create Hit object(s)
Channel->>Client: Return Channel object with search information
The sequence diagram above illustrates the high-level flow of the new search-related functionality. The client receives a WebsocketResponse, which is then used to create a Channel object. The Channel object then creates one or more Search objects, each of which contains one or more Hit objects. Finally, the Channel object is returned to the client, providing access to the search information. Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Awesome! Thanks @jjmaldonis |
Proposed changes
Adds the
Search
response for streaming requests. This is supported.I pulled the relevant code directly from
clients/listen/v1/rest/response.py
.Types of changes
What types of changes does your code introduce to the community Python SDK?
Checklist
Further comments
Bug report: https://discord.com/channels/1108042150941294664/1285161452763611158/1285161452763611158
Summary by CodeRabbit