Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LiveClient] Pass Self in Callbacks, Make Async/Sync Client StartUp Same #213

Merged

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Dec 15, 2023

This PR has a number of changes.

  1. Pass Self in Callbacks - This is to allow for other implementations to extend the class easier and to override functions and behaviors. Also always for access to class member variables.
  2. Make Async/Sync client the same - I thought there was some history in keeping the async client similar to what was implemented in v2, but I would prefer breaking the interface here than preserving the older mechanism. This keeps the Async and Sync LiveClients similar in design.
  3. Added some more debug statements sync live client that were missing.
  4. Simplified the example (adds on to the work done in Updates to README, examples, and More PyDocs #209

Was working on a PR to have the https://github.com/deepgram/streaming-test-suite use the Python SDK v3 and in order to get the options for transcription (vtt, srt) easier, that work would highly benefit from item 1 in this list.

Tested using: deepgram-sdk==v3.0.0-dev.14
Made sure all streaming examples work fine and also consumable from an external repo.

SandraRodgers
SandraRodgers previously approved these changes Dec 15, 2023
@davidvonthenen davidvonthenen merged commit c488adc into deepgram:main Dec 15, 2023
1 check passed
@davidvonthenen davidvonthenen deleted the live-client-inheritance branch December 15, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants