Fix Dynamic Loading of PyAudio #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidvonthenen
force-pushed
the
dyv-experiment-v3
branch
from
28235bb to
2bfa612
Compare
davidvonthenen
force-pushed
the
dyv-experiment-v3
branch
from
2bfa612 to
536831f
Compare
SandraRodgers
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix was Dynamic Loading of PyAudio. I didn't want to place the dependency of loading PyAudio for all SDK operations even if it were doing something simple like processing prerecorded audio. Requiring PyAudio to be installed forced users to also have port audio install even if they weren't using the Microphone. This now does it dynamically.
As a consequence, I cleaned up the pip installs and restored some of the functionality that @SandraRodgers has for the examples:
requirements.txt- needed for the functionality of the library itselfrequirements-dev.txt- only needed if you plan on doing dev work on the SDKexamples/requirements-examples.txt- only needed if you plan on running the examplesMade sure all examples works as intended! and made sure an external project is able to consume the library correctly PR pending (https://github.com/deepgram-starters/deepgram-python-starters) which is testable from this version in PyPi
3.0.0-dev.11.