Restructure Python v3 (Part 7) - Support API Versioning #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidvonthenen
force-pushed
the
restructure-project-part7
branch
2 times, most recently
from
7400209 to
0f5c285
Compare
SandraRodgers
previously approved these changes
Nov 12, 2023
SandraRodgers
dismissed
their stale review
The merge-base changed after approval.
Restructure Pyhon v3 (Part 3) Restructure Python v3 (Part 5) - Rename files Restructure Python v3 (Part 7) - Support API Versioning
davidvonthenen
force-pushed
the
restructure-project-part7
branch
from
0f5c285 to
71cbc9a
Compare
lukeocodes
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on this PR #156, #172, #173, #174, #175, and #176 to restructure the project. The goal is to do this in smaller chunks so the work is not finished in this PR. The PR merges to main so the PR is going to look messy until the dependent PR is merged.
Here is a clean diff in the meantime: dvonthenen:deepgram-python-sdk:restructure-project-part6...dvonthenen:deepgram-python-sdk:restructure-project-part7
Notable changes:
Verified that all existing demos work:
examples/demo_prerecorded.py,examples/demo_live.py, andexamples/demo_manage.py.Added a new example called
demo_versioning.pywhich demonstrates how the support for concurrent versioning should be handled. The example shows usingdeepgram.manage.get_projects()which uses the latest API version toget_projects(). Subsequently, there is another call todeepgram.manage_v1.get_projects()which gets the API call forv1where latest does not need to equalv1but both are accessible.