Implement the debuglevel JSON-RPC method #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
davecgh
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Looks good and confirmed it matches up with dcrd.
I originally was reviewing commit by commit and started writing up a review noting the parsing implementation wasn't handling the comma and all and that it should use the same one as the config parsing, but then I noticed you did that in the next commit.
This allows debug levels to be made more or less verbose at runtime, without requiring an application restart to change the config. The semantics and usage is identical to dcrd's debuglevel method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows debug levels to be made more or less verbose at runtime, without requiring an application restart to change the config.
The semantics and usage is identical to dcrd's debuglevel method.
Closes #1184.