wallet: Avoid multiple BlockHash() calculations #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this would be naturally checked later in the startup sync process, doing it in the p2p package just after receiving the header message avoids performing useless work if the peer is misbehaving.
This moves the code that initializes a batch of wallet.BlockNodes to outside the cfilter fetching code during initial sync. This will make it easier to move around code in later refactorings.
This is not currently used for anything.
This makes a change to the block node initialization code to, instead of calculating the block hash of each header, use the PrevBlock member of the header when multiple headers are available. This is safe to do because the lower P2P level has already validated that a received header batch connects in sequence (and therefore the PrevBlock of a header actually is equal to the prior header's block hash). This avoids unnecessarily performing duplicate work in calculating the block hash and reduces overall cpu usage, specially during the initial sync process.
This changes the signature of the ExtendMainChain functions in the wallet and udb to directly take header's block hash instead of recalculating. This avoids having to re-hash a header that has already been hashed earlier in the call stack, reducing both cpu and allocated space requirements during the initial sync process.
jrick
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to the wallet, spv syncing and peer packages to avoid having to hash the exact same header multiple times.
This improves both cpu and memory allocation performance during the initial sync process.
On an informal sync on mainnet using spvconnect, this reduces the space allocated by
BlockHash()calls by ~60% and the time spent in these functions by ~72%.