-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Entry points #78
Open
dubhsuil
wants to merge
24
commits into
deconst:master
Choose a base branch
from
dubhsuil:entry-points
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Continues from deconst#76 * Closes deconst#73 * Alpine 3.8 * Pip is now provided in base python3 package * Placeholder to remove build deps for security and size (needs runtime testing) * Use new Python3 venv builtin (pyvenv is deprecated) * MAINTAINER is deprecated * Use latest pip packages in requirements * Update gitignore
… the entrypoints are properly exposed. There is plenty more cleanup to be done, but this gets things working.
… this is a result of my changes, or existing problems
Merged
…ires the name of our extension in order for sphinx to load it. Many small changes aside from that as I try to massage things into place.
…ally to a workable state.
…nto entry-points
…phinx into entry-points
…roducing inaccurate output. Work continues...
…ual copying of files is not yet working though.
…de related issues in the output namely the right quotation mark (\u2019) and the paragraph symbol (\u00b6). Also, in order to get assets working, I had to rewrite the functionality into "calculate_offsets" because the rest of writer was not able to properly initialize.
…e working though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
setup.py
file to the extension IOT properly expose entry points to the environment. Includes many older commits as I am piggy-backing off of the work of others. I am raising this as a WIP PR mainly to show the changes being made and invite any thoughts from reviewers.This change may show the need for a greater code cleanup, as using
setup.py
circumvents some things added to files like__init__.py
, but there is a discussion to be had on that.