Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faq #922

Merged
merged 8 commits into from
Dec 4, 2023
Merged

Faq #922

merged 8 commits into from
Dec 4, 2023

Conversation

mkst
Copy link
Collaborator

@mkst mkst commented Nov 30, 2023

Creating a PR to gather feedback.

Closes #915

@marijnvdwerf
Copy link
Collaborator

(Terse because I’m on mobile. Nice job on adding the faq)

  • Textual content should be left aligned instead of justified for easier reading
  • Headings should probably have an id/name and way to get a /faq#what-is-a-scratch link
  • Wouldn’t it be easier (editing-wise) to have the faq in a md file that gets turned into TS on compile time? (E.g https://nextjs.org/docs/app/building-your-application/configuring/mdx)
  • Not sure if the page is long enough, but either a TOC or making sections collapsible could be a good way to help people get the answer they’re looking for
  • Some info about the scoring algorithm?
  • Maybe the longer paragraphs (good length btw!) could use some emphasis or links to make them a bit more visually engaging.

<h2 className={subtitle}>Can you add 'X' platform, e.g. PlayStation 3?</h2>
<p className="my-4">
The platforms that decomp.me supports are driven by the support for those platforms in the underlying tools that make up decomp.me.
If these tools support the architecture for the new platform, and you have the compiler available, it is a straightforward process to add it to decomp.me.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This answer seems unfinished. I think we need to direct people somewhere. Either a feature request issue template, or just Discord?

I think adding issue templates would be a good idea as well. Especially for requests like adding a preset (platform, version, name, flags), or a compiler/platform, so you can get all the required information at once.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A contributing document that explains how to add a new compiler/platform (not preset - they're in the db now!) would be in order

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I don't think it should hold up this PR. it's something that can be an issue and later created / linked to from this page

Copy link

@jpburnett jpburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts. Not sure if a "How do I make a scratch" would make sense? There is sections explaining that, but that could be more of a tutorial rather than FAQ?

frontend/src/app/(navfooter)/faq/page.tsx Outdated Show resolved Hide resolved
frontend/src/app/(navfooter)/faq/page.tsx Outdated Show resolved Hide resolved
frontend/src/app/(navfooter)/faq/page.tsx Outdated Show resolved Hide resolved
frontend/src/app/(navfooter)/faq/page.tsx Outdated Show resolved Hide resolved
@ethteck
Copy link
Member

ethteck commented Dec 4, 2023

This is a great start that I think can be improved over time with some of the more QOL features like @marijnvdwerf mentioned. If no one has any objections, I think let's merge this soon

@mkst mkst merged commit c6c5b77 into main Dec 4, 2023
6 checks passed
@mkst mkst deleted the faq branch December 4, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an FAQ
5 participants