parseInt(new_scratch_preset) #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably handle the initial case where parseInt returns NaN |
|
bleurgh. |
|
I give up :) |
mkst
force-pushed
the
fixup-preset-id-localstorage
branch
from
eb7f6cb to
1d3469c
Compare
|
nah this change is junk. |
mkst
force-pushed
the
fixup-preset-id-localstorage
branch
from
54acd42 to
1d3469c
Compare
ethteck
approved these changes
Nov 12, 2023
|
Right. am finally happy with this. I dont know if there is a better way that would replace the need for the |
bates64
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks good locally (and on Vercel)... the initial preset state is "Custom" but as soon as a platform is selected, the Preset works (for all platforms) - I dont know whether we care enough about that?
Fixes #907.