[WIP] Add Borland 3.1 compiler to MS-DOS platform #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkst
reviewed
Jan 27, 2025
backend/coreapp/compilers.py
Outdated
| 'cat "$INPUT" | unix2dos > dos_src.c && ' | ||
| "echo \"\$_hdimage = '+0 ${COMPILER_DIR} +1'\" > .dosemurc && " | ||
| '(HOME="." /usr/bin/dosemu -quiet -dumb -f .dosemurc -K . -E "D:\\bin\\bcc.exe -ID:\\include ${COMPILER_FLAGS} -c -oout.o dos_src.c") && ' | ||
| "rm .dosemurc && " |
There was a problem hiding this comment.
Don't need to worry about the rm, the execution is done in a sandbox
|
You'll need to update the asm-differ dependency in the poetry.lock once your PR has been merged there, but other than that, this looks good to go! |
mkst
reviewed
Jan 28, 2025
| @@ -59,6 +59,8 @@ jobs: | |||
| run: |- | |||
| wget https://github.com/OmniBlade/binutils-gdb/releases/download/omf-build/omftools.tar.gz | |||
There was a problem hiding this comment.
can you change this so we only extract jwasm (and same for Dockerfile if appropriate)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
simonlindholm/asm-differ#178
decompme/compilers#28