Use CredentialResponse as defined in the Credential Manifest #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by apelt in #32, the WACI-DIDComm Interop Profile is outdated since it does not reflect the CredentialResponse defined in the Credential Manifest.
Also noted in #32, step 5 in the credential issaunce process displays an authentication proof that does not appear to be required.
This PR is intended to address both of these issues. The Authentication Proof has been removed and the CredentialResponse has been used as defined in the Credential Manifest.
EDIT: I've just moved the changes from
spec/v1.0/spec.mdtospec/spec.md