Readme Improvements #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kvnn
changed the title
formats
OR13
approved these changes
Jan 16, 2023
| @@ -219,6 +219,12 @@ Message Format: | |||
| "goal_code": "<goal-code>", | |||
| "comment": "some comment" | |||
| }, | |||
| "formats": [ | |||
There was a problem hiding this comment.
Is this a valid DIDComm message?
As far as I know, format is not a message header https://identity.foundation/didcomm-messaging/spec/#message-headers
There was a problem hiding this comment.
I agree this formats mapping is extraneous as the format is found on the actual attachment
There was a problem hiding this comment.
if needed, it should be included inside the body I think.
| @@ -283,7 +289,7 @@ Description of fields: | |||
| - `comment` -- an optional field that provides human readable information about the issued credential, so it can be evaluated by human judgment. Follows [DIDComm conventions for l10n](https://github.com/hyperledger/aries-rfcs/tree/main/features/0043-l10n/README.md). | |||
| - `attachments` -- an array of attachments containing the issued credentials. | |||
|
|
|||
| If the issuer wants an acknowledgement that he issued credential was accepted, this message must be decorated with the `~please-ack` decorator using the `OUTCOME` acknowledgement request. Outcome in the context of this protocol means the acceptance of the credential in whole, i.e. the credential is verified and the contents of the credential are acknowledged. Note that this is different from the default behavior as described in [0317: Please ACK Decorator](https://github.com/hyperledger/aries-rfcs/tree/main/features/0317-please-ack/README.md). It is then best practice for the new Holder to respond with an explicit `ack` message as described in the please ack decorator RFC. | |||
| If the issuer wants an acknowledgement that the issued credential was accepted, this message must be decorated with the `~please-ack` decorator using the `OUTCOME` acknowledgement request. Outcome in the context of this protocol means the acceptance of the credential in whole, i.e. the credential is verified and the contents of the credential are acknowledged. Note that this is different from the default behavior as described in [0317: Please ACK Decorator](https://github.com/hyperledger/aries-rfcs/tree/main/features/0317-please-ack/README.md). It is then best practice for the new Holder to respond with an explicit `ack` message as described in the please ack decorator RFC. | |||
There was a problem hiding this comment.
This ~please-ack header will need to be changed as there is no notion of decorators in didcommv2 but that shouldn't hold up this PR.
There was a problem hiding this comment.
it should conform to ACKs in DIDComm spec
| @@ -219,6 +219,12 @@ Message Format: | |||
| "goal_code": "<goal-code>", | |||
| "comment": "some comment" | |||
| }, | |||
| "formats": [ | |||
There was a problem hiding this comment.
I agree this formats mapping is extraneous as the format is found on the actual attachment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.