feat: opt out for vrm export improvements #6193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the details panel list of VRM export blocking items.
…n the details panel.
…rver in WearablesFetchingHelper.cs.
…e the Details Panel view. Added VRMDetailsController to handle the Details Panel behavior.
…rectly in the Details Panel. Updated VRMItemDetails following FIGMAs.
…ent. Updated the concrete implementation to handle the complete UX flows. Updated BackpackEditorHUDController to handle the new Details Panel. Updated BackpackEditorV2Plugin to initialize the VRMDetailsController. Updated WearablesSection.prefab to hold the new Details Panel section. Updated BackpackEditorHUDV2.prefab accordingly. Added VRMExportDetailsPanel.prefab
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 7SDK 6More |
sandrade-dcl
reviewed
May 7, 2024
...cripts/MainScripts/DCL/Controllers/HUD/BackpackEditorHUDV2/VRMExport/VRMDetailsController.cs
Outdated
Show resolved
Hide resolved
sandrade-dcl
approved these changes
May 7, 2024
lorux0
approved these changes
May 7, 2024
.../MainScripts/DCL/Controllers/HUD/BackpackEditorHUDV2/VRMExport/VRMDetailItemComponentView.cs
Outdated
Show resolved
Hide resolved
...pts/MainScripts/DCL/Controllers/HUD/BackpackEditorHUDV2/VRMExport/VRMDetailsComponentView.cs
Outdated
Show resolved
Hide resolved
...pts/MainScripts/DCL/Controllers/HUD/BackpackEditorHUDV2/VRMExport/VRMDetailsComponentView.cs
Outdated
Show resolved
Hide resolved
lorux0
reviewed
May 7, 2024
...cripts/MainScripts/DCL/Controllers/HUD/BackpackEditorHUDV2/VRMExport/VRMDetailsController.cs
Outdated
Show resolved
Hide resolved
lorux0
reviewed
May 7, 2024
...cripts/MainScripts/DCL/Controllers/HUD/BackpackEditorHUDV2/VRMExport/VRMDetailsController.cs
Show resolved
Hide resolved
…ified in the scene during development. Adjusted prefabs to better align with screen size changes.
…Added wearableCanBeUnEquipped property to VRMItemModel. Refactored VRMDetailsController and BackpackEditorHUDController to use a data structure that holds wearable urn and whether it can be unequipped. Added active state update for action button in VRMDetailItemComponentvView. Added canBeUnEquipped in NFTDataDTO. Refactored WearableGridController to use the new extension method to check if a wearable can be unequipped.
…-opening again. Fixed details panel export button not working. Small code improvements. Added missing unsubscribe calls in several classes.
anicalbano
approved these changes
May 16, 2024
sandrade-dcl
approved these changes
May 17, 2024
AlejandroAlvarezMelucciDCL
changed the title
AlejandroAlvarezMelucciDCL
deleted the
feat/opt-out-for-vrm-export-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR adds a Details Panel in the Backpack view that is available when the user has more than one wearable with the VRM block export feature turned on.
The Details Panel lets the user see a list of those items and allows for quick unequip/equip from that list and has a dynamic Export button that reacts to changes to equipped wearables.
...
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
copilot:summary