fix: unify to entity.id the scene_id by comms, remove unused code #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
not omit id fill id when it's not present
leanmendoza
force-pushed
the
fix/unify-scene-id-by-comms
branch
from
e81556b to
90ae366
Compare
gonpombo8
approved these changes
Apr 9, 2024
Ludmilafantaniella
approved these changes
Apr 9, 2024
pravusjif
approved these changes
Apr 9, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Use always the
entity.idas scene identifier by comms. Right now the identifier changes if you're in the genesis city, world or custom realm.How to test the changes?
Jump to the beer scene using two tabs (that's why the guest=true is on):
https://play.decentraland.org/?explorer-branch=fix/unify-scene-id-by-comms&realm=sdk-team-cdn.decentraland.org%2Fipfs%2Fgoerli-plaza-test-psquad-demo-latest&skipSetup=true&guest=true&position=73%2C-7
If you pick up a glass, you have to be able to see it from the other tab.