fix: twitter not working on macOS in camera view #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
Ludmilafantaniella
approved these changes
Feb 1, 2024
popuz
approved these changes
Feb 1, 2024
m3taphysics
reviewed
Feb 1, 2024
| @@ -47,7 +47,7 @@ public class ThumbnailContextMenuController | |||
|
|
|||
| view.OnShareToTwitterRequested += () => | |||
| { | |||
| var description = "Check out what I'm doing in Decentraland right now and join me!"; | |||
| var description = "Check out what I'm doing in Decentraland right now and join me!".Replace(" ", "%20"); | |||
There was a problem hiding this comment.
Is there not a more standard way to handle URL encoding to avoid the duplication?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fixing URL encoding for Twitter links in camera reel #5812
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
copilot:summary