Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure the URN when equipping emotes is using the shortened URN #6051

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

m3taphysics
Copy link
Collaborator

What does this PR change?

Ensures that when NFT emotes are using the long URL that are stored within the profile, the backpack treats it as a shortened url.

...

How to test the changes?

  1. Equip an NFT emote & Close the backpack.
  2. Exit
  3. Rejoin and ensure the emotes are still assigned.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@m3taphysics m3taphysics requested review from davidejensen and removed request for davidejensen January 10, 2024 09:59
@m3taphysics m3taphysics changed the title Ensure the URN when equipping emotes is using the shortened URN fix: Ensure the URN when equipping emotes is using the shortened URN Jan 10, 2024
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Reviewed and approved by QA. This PR was tested on MacBook Pro (14.0) on both Browser and Desktop. I tested using the steps given and also changing locations, and the emotes NFT remains in the emotes menu.

Screen.Recording.2024-01-10.at.09.46.57.mov

@m3taphysics m3taphysics merged commit 19935b0 into dev Jan 10, 2024
11 checks passed
@m3taphysics m3taphysics deleted the fix/missing-nft-emotes branch January 10, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants