test: setting correct base url from about lambdas #6032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
Ludmilafantaniella
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
✅ Fix verified and approved.
Reviewed on Desktop & browser, as Guest and with a wallet, also tested from an incognito tab. Verified that in "Knights of Antrom" (144,-7), the assets within the different sections, in the backpack, remain visible after making a Realm changes (tested with all realms, but a short video was recorded showing one).
Screen.Recording.2023-12-28.at.12.02.32.mp4
LucasLioyQA
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
QA approved
Evidence: https://drive.google.com/drive/folders/18BcQkCRTW_is8OliU7Wjbos4KnI6Xo-b?usp=sharing
gonpombo8
approved these changes
Dec 29, 2023
Co-authored-by: Gon Pombo <[email protected]> Signed-off-by: Juan Ignacio Molteni <[email protected]>
Co-authored-by: Gon Pombo <[email protected]> Signed-off-by: Juan Ignacio Molteni <[email protected]>
hugoArregui
reviewed
Dec 29, 2023
hugoArregui
approved these changes
Dec 29, 2023
Signed-off-by: Juan Ignacio Molteni <[email protected]>
Signed-off-by: Juan Ignacio Molteni <[email protected]>
Signed-off-by: Juan Ignacio Molteni <[email protected]>
Signed-off-by: Juan Ignacio Molteni <[email protected]>
Signed-off-by: Juan Ignacio Molteni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
When the main realm was introduced, an issue started appearing in which the
baseURLof theRealmInfowas incorrectly set.This PR changes that. If the real is being set via main, the
baseURLwill be grabbed fromabout/lambdas, using just the hostname.How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
copilot:summary