fix: the profile picture display the full image of the avatar

[sandrade-dcl]

What does this PR change?

Fix #5967

During the flow of the sing in, if the avatar was customized, we saw that the avatar profile picture was displayed as the full body instead of just the head.

Now the avatar snapshot is saved correctly:

How to test the changes?

1. Launch the explorer as guest.
2. You should enter in the SignIn flow.
3. Apply several changes in your avatar during the avatar customization process. (body shape, hair style and color, change the clothes)
4. Go to the next screen and accept the terms and conditions.
5. Check that, after the world is loaded, your profile picture shows only the face of your customized avatar.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

🤖[deprecated] Generated by Copilot at 48e28b9

This pull request adds a new flag isWaitingToBeSavedAfterSignUp to the backpack data store and the HUD controllers for the backpack editor and the signup flow. The flag is used to trigger a terms of service agreement step before saving the backpack in the signup process. The HUD controllers are updated to subscribe and react to the flag changes.

[github-actions]

After the CI passes:

Web

This branch can be previewed at:

• https://play.decentraland.org/?explorer-branch=fix/profile-picture-display-the-full-image-of-the-avatar
• https://play.decentraland.zone/?explorer-branch=fix/profile-picture-display-the-full-image-of-the-avatar

Desktop:

If you have the launcher installed (download launcher) you can press open on the following link:

• Open custom protocol
• Open custom protocol with Developer Mode

SDK 6/7:

• Open SDK7 scenes playground
• Open SDK7 scenes in preview
• Open SDK6 scenes in preview

More

• Code coverage report: https://renderer-artifacts.decentraland.org/branch-coverage/fix/profile-picture-display-the-full-image-of-the-avatar
• Benchmark report: https://renderer-artifacts.decentraland.org/branch-benchmark/fix/profile-picture-display-the-full-image-of-the-avatar/index.html

[Ludmilafantaniella]

❌ fix failed. Despite the profile picture displaying correctly, the avatar customization changes are not persisting. After multiple modifications, upon loading the world, the avatar reverts to the default state as if no changes were made.

Screen.Recording.2023-11-27.at.16.16.16.mp4

@sandrade-dcl

[sandrade-dcl]

@Ludmilafantaniella you can re-test, I've fixed it.

[Ludmilafantaniella]

✅ Fix verified on both Desktop and browser. Customized changes persist after world load, and the profile picture displays the head of the avatar as expected.

Screen.Recording.2023-11-27.at.17.59.46.mov

[lorux0]

I dont really feel confortable on the back and forth from signup to backpack through datastore. Perhaps an interface for saving the profile could have been injected into the signup? Anyway im approving

[Kinerius]

I dont really feel confortable on the back and forth from signup to backpack through datastore. Perhaps an interface for saving the profile could have been injected into the signup? Anyway im approving

I agree, we rely too much on singletons there