feat: sdk7 debug panel scene metrics #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
pravusjif
added
No QA Needed
Ludmilafantaniella
approved these changes
Nov 27, 2023
Kinerius
approved these changes
Nov 28, 2023
unity-renderer/Assets/DCLPlugins/ECS7/ECSComponents/GltfContainer/GltfContainerHandler.cs
Outdated
Show resolved
Hide resolved
unity-renderer/Assets/DCLPlugins/ECS7/ECSComponents/Material/MaterialHandler.cs
Outdated
Show resolved
Hide resolved
…into feat/sdk7-debug-panel-scene-metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug panel scene metrics were not implementet, now it's hooked up to the same datastore logic that SDK6 uses.
Issue: decentraland/sdk#1032
Copilot summary
🤖[deprecated] Generated by Copilot at a219ba6
This pull request adds a debug mode feature to the GltfContainer, Material, and MeshRenderer components. The debug mode allows these components to update the scene metrics data store with information about the loaded and unloaded assets. The pull request also refactors some classes to use fields instead of parameters and fixes some typos and inconsistencies. The pull request modifies several assembly definition files to add the necessary references to the DataStore and DebugConfig namespaces. The pull request also updates the tests to pass the debug config object to the constructors of the component handlers.
QA TEST INSTRUCTIONS