Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: advanced debug menu #1781

Merged
merged 60 commits into from
Aug 17, 2024
Merged

Feat: advanced debug menu #1781

merged 60 commits into from
Aug 17, 2024

Conversation

NickKhalow
Copy link
Contributor

@NickKhalow NickKhalow commented Aug 15, 2024 •
edited
Loading

How to Test

  1. Launch app without -debug flag, check the debug panel
  2. Launch app with -debug flag, check the debug panel again

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

NickKhalow added 30 commits August 6, 2024 14:08
@NickKhalow
base structure
11bd359
@NickKhalow
Merge branch 'main' into feat/connection-status-panel
89c1342
@NickKhalow
ConnectionStatusPanel dependencies propagation
3f00c59
@NickKhalow
Merge branch 'main' into feat/connection-status-panel
bdc4a51
@NickKhalow
ui
fb0bfaf
@NickKhalow
Merge branch 'main' into feat/connection-status-panel
fc1acf4 
# Conflicts:
#	Explorer/Assets/Scripts/Global/Dynamic/DynamicWorldContainer.cs
@NickKhalow
StatusEntry base
e2000d1
@NickKhalow
fields naming for status entries
903a972
@NickKhalow
StatusEntry refs
2d28050
@NickKhalow
BadgeView
57b3137
@NickKhalow
add settings
bd422ed
@NickKhalow
UpdateCursorInputSystem ensure has mouse
6d53c41
@NickKhalow
Merge branch 'main' into feat/connection-status-panel
0ccc47e 
# Conflicts:
#	Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
#	Explorer/Assets/DCL/UI/MainUIContainer/MainUIContainer.prefab
#	Explorer/Assets/Scripts/Global/Dynamic/DynamicWorldContainer.cs
@NickKhalow
bind status
4485ce3
@NickKhalow
bind panel
5471301
@NickKhalow
add panel to MainUIController.cs
f15c0c8
@NickKhalow
fix mistype
483842f
@NickKhalow
remove Awake
3c45fa7
@NickKhalow
pass mvcManager
3210ac8
@NickKhalow
ErrorPopup View/Controller
e4de7a7
@NickKhalow
ErrorPopup pass state to view
2142d22
@NickKhalow
IUserInAppInitializationFlow integration
a68717d
@NickKhalow
UpdateStatusEntry clarify
e58cb1c
@NickKhalow
add popup to Global Plugins Settings
b14ed42
@NickKhalow
override connection quality for debug purposes
ec0dc43
@NickKhalow
connection quality in panel
d8a04e9
@NickKhalow
CurrentSceneInfo
63f4d0c
@NickKhalow
display scene status
1ada589
@NickKhalow
show button
7c0d180
@NickKhalow
StatusFrom remove redundant code
6e2e326
@NickKhalow NickKhalow self-assigned this Aug 15, 2024
@NickKhalow NickKhalow linked an issue Aug 15, 2024 that may be closed by this pull request
Disable Debug Camera & Debug Menu in build #1738
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 15, 2024 •
edited
Loading

badge

New build in progress, come back later!

Ludmilafantaniella
Ludmilafantaniella approved these changes Aug 15, 2024
View reviewed changes
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Feat Verified and Approved by QA
The feature has been tested and is working as expected. When launching the app without the -debug flag, only some options are visible. With the -debug flag, all options are accessible.

image

@m3taphysics m3taphysics self-requested a review August 15, 2024 12:29
@NickKhalow
Merge branch 'main' into feat/advanced-debug-menu
894a848 
# Conflicts:
#	Explorer/Assets/DCL/Character/CharacterCamera/Systems/ApplyCinemachineCameraInputSystem.cs
@NickKhalow NickKhalow enabled auto-merge (squash) August 16, 2024 13:50
lorux0
lorux0 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@lorux0 lorux0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but the refactor gets pending for later!

@NickKhalow NickKhalow merged commit c8c9dcd into main Aug 17, 2024
5 checks passed
@NickKhalow NickKhalow deleted the feat/advanced-debug-menu branch August 17, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ludmilafantaniella Ludmilafantaniella Ludmilafantaniella approved these changes

@lorux0 lorux0 lorux0 approved these changes

@dalkia dalkia dalkia approved these changes

@m3taphysics m3taphysics m3taphysics approved these changes

Assignees

@NickKhalow NickKhalow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable Debug Camera & Debug Menu in build
6 participants
@NickKhalow @m3taphysics @dalkia @lorux0 @Ludmilafantaniella @RominaMarchetti