Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Meteor 2.6 #694

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Upgrade to Meteor 2.6 #694

merged 1 commit into from
Feb 16, 2022

Conversation

ebroder
Copy link
Member

@ebroder ebroder commented Feb 9, 2022

Meteor 2.6 has been released, but hasn't yet been marked as the "recommended release", so has to be manually selected with meteor update --release 2.6.

The primary change here is support for MongoDB 5.0, including upgrading to a new major version of the node mongo driver, which is somewhat pressing as MongoDB Atlas will be imminently upgrading to 5.0 (within the next week or two). So long as we're using Meteor's wrappers around mongo, this should be a transparent upgrade; the main consideration is that underlying node library has changed pretty significantly, which potentially affects anything using rawCollection.

Fortunately the one place that we use rawCollection (our idempotent re-implementation of dropIndex) still works with the new API. We do need to worry about any meteor packages that we've included that are also using rawCollection (or rawDatabase). Fortunately, I think that's just xolvio:cleaner, and while it is using a deprecated method (Collection.remove), it is only deprecated not broken.

The MongoDB driver did switch the name of the projection option from fields to projection. I opted not to migrate in this PR as (a) Meteor is maintaining a compatibility layer (b) the type declarations haven't been updated yet which would make it annoying, but we should eventually come back and do that.

@ebroder ebroder requested a review from zarvox February 9, 2022 17:43
@ebroder
Copy link
Member Author

ebroder commented Feb 9, 2022

(The full migration guide is available at https://guide.meteor.com/2.6-migration.html)

@ebroder
Copy link
Member Author

ebroder commented Feb 11, 2022

@zarvox There's definitely no rush to you to review this, but just as an FYI, I will likely force-merge if Atlas upgrades us to 5.0 before you have a chance to look at it.

@ebroder
Copy link
Member Author

ebroder commented Feb 16, 2022

Our Mongo Atlas cluster was upgraded to 5.0, and I'm seeing some weird behavior with multiple subscriptions that deliver the same record, so I'm going to go ahead and force-merge this since I suspect there's some behavior change here.

@ebroder ebroder merged commit bf2f128 into main Feb 16, 2022
@ebroder ebroder deleted the evan/meteor-2.6 branch February 16, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant