Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meteor 2.6 has been released, but hasn't yet been marked as the "recommended release", so has to be manually selected with
meteor update --release 2.6
.The primary change here is support for MongoDB 5.0, including upgrading to a new major version of the node mongo driver, which is somewhat pressing as MongoDB Atlas will be imminently upgrading to 5.0 (within the next week or two). So long as we're using Meteor's wrappers around mongo, this should be a transparent upgrade; the main consideration is that underlying node library has changed pretty significantly, which potentially affects anything using
rawCollection
.Fortunately the one place that we use
rawCollection
(our idempotent re-implementation ofdropIndex
) still works with the new API. We do need to worry about any meteor packages that we've included that are also usingrawCollection
(orrawDatabase
). Fortunately, I think that's justxolvio:cleaner
, and while it is using a deprecated method (Collection.remove
), it is only deprecated not broken.The MongoDB driver did switch the name of the projection option from
fields
toprojection
. I opted not to migrate in this PR as (a) Meteor is maintaining a compatibility layer (b) the type declarations haven't been updated yet which would make it annoying, but we should eventually come back and do that.