Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send puzzle-solved notifications only to the solved-puzzle's hunt #1992

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

zarvox
Copy link
Contributor

@zarvox zarvox commented Jan 15, 2024

Fix an unindexed Puzzles find query that also probably wants to limit to the current hunt while I'm here.

Fixes #1991.

Fix an unindexed Puzzles find query that also probably wants to limit to
the current hunt while I'm here.

Fixes #1991.
@zarvox zarvox requested a review from ebroder January 15, 2024 20:05
Copy link
Member

@ebroder ebroder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are you sure that there's not also a bug with tagging a puzzle from the wrong hunt?

@zarvox
Copy link
Contributor Author

zarvox commented Jan 15, 2024

Yes, the logic here is sufficient to explain the observed behavior (we happened to have at least two group:runaround tags in the DB, and the puzzle we saw the notification for was meta-for:runaround, and we didn't have a hunt selector on this query). I checked all the places we fetch tags in the client components, and these are the only ones that didn't specify either an _id or a hunt.

@zarvox zarvox merged commit 028e0a8 into main Jan 15, 2024
1 check passed
@zarvox zarvox deleted the zarvox-fix-chat-hook-tag-bug branch January 15, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants