Add a small bounce when bookmarking a puzzle #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebroder
commented
Jan 6, 2024
Comment on lines
+8
to
+22
| interface BookmarkButtonProps<As extends React.ElementType = React.ElementType> | ||
| extends React.HTMLAttributes<HTMLElement> { | ||
| puzzleId: string; | ||
| bookmarked: boolean; | ||
| as?: As; | ||
| } | ||
|
|
||
| type BookmarkButtonType = < | ||
| As extends React.ElementType = typeof Button | ||
| >( | ||
| props: BookmarkButtonProps<As> & Omit<React.ComponentPropsWithRef<As>, keyof BookmarkButtonProps>, | ||
| context?: any, | ||
| ) => React.ReactNode; | ||
|
|
||
| const BookmarkButton: BookmarkButtonType = React.forwardRef<HTMLElement, BookmarkButtonProps>(({ |
There was a problem hiding this comment.
For the record, these type shenanigans are pretty heavily inspired by some similar type shenanigans in react-bootstrap.
zarvox
reviewed
Jan 6, 2024
| icon={bookmarked ? faStarSolid : faStarRegular} | ||
| beat={animateBookmark} | ||
| onAnimationEnd={onAnimationEnd} | ||
| style={{ '--fa-animation-iteration-count': 1, '--fa-animation-duration': '0.5s' }} |
There was a problem hiding this comment.
This feels just a little slow -- can we make the duration here, say, 0.2s instead?
ebroder
force-pushed
the
evan/animations
branch
from
9df41bf to
1f90a46
Compare
zarvox
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-01-05.at.2.14.13.PM.mov