Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Have build explicitly trigger the deploy #37

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Conversation

deadlydog
Copy link
Owner

Previously we had the deployment workflow trigger when a build workflow completed. The problem is that the deployment workflow would trigger even if the build workflow failed; GitHub Actions does not provide a way of only triggering a workflow only if the dependent workflow succeeded.

To solve this problem we are reversing the dependency. Instead of the deployment workflow listening for the build workflow to complete, the build workflow will explicitly trigger the deployment workflow, and only when it completes successfully.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Overall Project 80.53% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Overall Project 80.53% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Overall Project 80.53% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Overall Project 80.53% 🍏

There is no coverage information present for the Files changed

@deadlydog deadlydog merged commit 2c18099 into main Oct 2, 2023
6 of 7 checks passed
@deadlydog deadlydog deleted the HaveCiTriggerCd branch October 2, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant