Updating the instantiation of the notifier #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an instance of the slack notifier, a parameter for the team was being used. That is no longer needd, this commit updates that. Also, when I first installed the project it didn't work, cause it installed slack-notifier gem version 0.5, which is very old, this patch fixes the gem version to be the latest.
When new patches are submitted they have been different type and they were not being followed. This commit adds a listener for that kind of event. This commit also includes a couple of cosmetic changes.
The current code was not considering the case when the patchset is abandoned. We realized we were informing the team about abandoned patches so it is better to let gerrit do it. This patch adds the code to start notifying about abandoned patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an instance of the slack notifier, a parameter for
the team was being used. That is no longer needd, this commit
updates that.
Also, when I first installed the project it didn't work, cause
it installed slack-notifier gem version 0.5, which is very old,
this patch fixes the gem version to be the latest.