Update php versions in pipelines (#74)

* Update php versions in pipelines * cs
dc-Ragnarok · Jan 25, 2024 · 24d22de · 24d22de
1 parent 9becea9
commit 24d22de
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 31 deletions.
diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml
@@ -13,11 +13,13 @@ jobs:
     - name: Install PHP 8.1
       uses: shivammathur/setup-php@v2
       with:
-        php-version: 8.1
+        php-version: 8.3
     - name: Install packages
       run: composer install --no-progress
     - name: Run CS
       run: composer cs
+    - name: Verify namespaces
+      run: bash util/verify-namespacing.sh
 
   phpmd:
     runs-on: ubuntu-20.04
@@ -26,35 +28,8 @@ jobs:
     - name: Install PHP 8.1
       uses: shivammathur/setup-php@v2
       with:
-        php-version: 8.1
+        php-version: 8.3
     - name: Install packages
       run: composer install --no-progress
     - name: Run MD
       run: composer md
-
-  namespace-check:
-    runs-on: ubuntu-20.04
-    steps:
-    - uses: actions/checkout@v3
-    - name: Install PHP 8.1
-      uses: shivammathur/setup-php@v2
-      with:
-        php-version: 8.1
-    - name: Verify namespaces
-      run: bash util/verify-namespacing.sh
-
-  syntax-check:
-    runs-on: ubuntu-20.04
-    strategy:
-      fail-fast: false
-      matrix:
-        php: [ '8.1', '8.2', '8.3' ]
-    steps:
-      - uses: actions/checkout@v3
-      - name: Install PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: ${{ matrix.php }}
-
-      - name: Verify linting for ${{ matrix.php }}
-        run: ./util/verify-namespacing.sh
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: [ '8.1', '8.2', '8.3' ]
+        php: [ '8.1', '8.2', '8.3', '8.4' ]
 
     steps:
       - uses: actions/checkout@v3
@@ -23,6 +23,9 @@ jobs:
         with:
           php-version: ${{ matrix.php }}
 
+      - name: Verify syntax for ${{ matrix.php }}
+        run: ./util/verify-namespacing.sh
+
       - name: Install packages
         run: composer install --prefer-dist --no-progress
 

diff --git a/src/Rest/Channel.php b/src/Rest/Channel.php
@@ -577,7 +577,7 @@ public function startThreadInForumChannel(
         MultipartBody|array $params,
         ?string $reason = null
     ): ExtendedPromiseInterface {
-        $forumChannelWithMessage = new class() extends Channel {
+        $forumChannelWithMessage = new class () extends Channel {
             public Message $message;
         };