Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛zx: correctly check if fdo ifaces is empty #595

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

FineFindus
Copy link
Contributor

Fixes an issue where instead of checking if fdo_standard_ifaces was empty, it was accidentally checked if the prefix string was empty. Found by (and thanks to) @Cobinja in 35c15c8#r138622943.

I totally blame clippy for not having a lint against this :)

@zeenix zeenix merged commit 29fef24 into dbus2:main Feb 16, 2024
7 checks passed
@FineFindus FineFindus deleted the fix/fdo-warning branch February 17, 2024 09:27
@zeenix
Copy link
Contributor

zeenix commented Feb 17, 2024

I totally blame clippy for not having a lint against this :)

They'd be happy to receive a report on this. 😉

@FineFindus
Copy link
Contributor Author

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants