Add SerializeTuple and use it for code generated by #[dbus_proxy] #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
requested changes
Jan 17, 2024
danieldg
force-pushed
the
proxy-dynamic-tuples
branch
2 times, most recently
from
fc0d7dc to
a8ce30b
Compare
zeenix
requested changes
Jan 18, 2024
danieldg
force-pushed
the
proxy-dynamic-tuples
branch
from
a8ce30b to
33548c8
Compare
|
@danieldg this got off my radar. All review comments addressed? |
|
I believe so. |
Still the case but ok, no biggie. I forgot to mention, we've started doing emoji prefixes in git commits. Could you please add those? Should be pretty easy with my gimoji tool. :) Then I can merge. |
danieldg
force-pushed
the
proxy-dynamic-tuples
branch
from
33548c8 to
928b313
Compare
Deserializing a Structure will result in a Structure that borrows file descriptors and strings from the source; similar to OwnedValue, add a distinct type to allow deserializing without borrows. This is needed to have zbus::Proxy::call return a Structure.
A bound of `for<'d> zvariant::DynamicDeserialize<'d>` on the result type of a call is sufficient to deserialize; use this bound instead of the stricter `DeserializeOwned + zvariant::Type`. Because there is a blanket impl of DynamicDeserialize for any type that implements Type + Deserialize, any call that was previously allowed will still be allowed after this change.
This allows using types that only implement DynamicType in macro-generated proxy functions.
danieldg
force-pushed
the
proxy-dynamic-tuples
branch
from
928b313 to
5696d5f
Compare
zeenix
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #542