-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with annotations and nested extensions #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-sheets
force-pushed
the
masheets/extend-derive
branch
from
April 24, 2023 17:49
abeeee0
to
10b3c73
Compare
matt-sheets
commented
Apr 24, 2023
dburgener
reviewed
Apr 25, 2023
Can we add another test case for something like this?
And make sure the alias applies appropriately |
Previously any annotations on a nested extension would be ignored. The code will now properly propagate the annotations to the types created by the extensions.
Adding new test case for aliases on nested extend
We now pass extend_annotations by reference and just clone the values we are transfering.
matt-sheets
force-pushed
the
masheets/extend-derive
branch
from
May 2, 2023 15:25
789d853
to
f7c138a
Compare
dburgener
reviewed
May 2, 2023
dburgener
approved these changes
May 2, 2023
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously any annotations on a nested extension would be ignored. The code will now properly propagate the annotations to the types created by the extensions.