Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with annotations and nested extensions #192

Merged
merged 6 commits into from
May 2, 2023

Conversation

matt-sheets
Copy link
Collaborator

Previously any annotations on a nested extension would be ignored. The code will now properly propagate the annotations to the types created by the extensions.

@matt-sheets matt-sheets force-pushed the masheets/extend-derive branch from abeeee0 to 10b3c73 Compare April 24, 2023 17:49
src/lib.rs Show resolved Hide resolved
@matt-sheets matt-sheets linked an issue Apr 24, 2023 that may be closed by this pull request
src/lib.rs Outdated Show resolved Hide resolved
@dburgener
Copy link
Owner

Can we add another test case for something like this?

domain foo {
    resource bar {}

    @alias(baz)
    extend bar {}
}

And make sure the alias applies appropriately

Previously any annotations on a nested extension would be ignored.  The
code will now properly propagate the annotations to the types created by
the extensions.
Adding new test case for aliases on nested extend
We now pass extend_annotations by reference and just clone
the values we are transfering.
@dburgener dburgener merged commit b78610d into dburgener:main May 2, 2023
@dburgener
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding annotations on nested extensions doesn't work
2 participants