Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the timestamp of the first file within the GZIP archive for published_at #322

Closed
wants to merge 1 commit into from

Conversation

aranke
Copy link
Member

@aranke aranke commented Jun 4, 2024

Description

Use the timestamp of the first file within the GZIP archive for published_at instead of hard-coding to 1970-01-01

Sample PR: https://github.com/dbt-labs/hub.getdbt.com-test/pull/251/files

hubcap/records.py Dismissed Show dismissed Hide dismissed
@joellabes
Copy link
Contributor

This was intentionally removed in #141 because it led to a ridiculous number of redundant PRs being opened, what makes you want to bring it back? (Your approach is admittedly much more idempotent than just using the current time).

Not averse to it, but we don't display it anywhere so I'm not sure what filling it out solves.

@aranke
Copy link
Member Author

aranke commented Jun 4, 2024

@joellabes I want to avoid errors like this one: dbt-labs/dbt-core#10260. Currently, each version bump of dbt-utils will break dbt-core because the deps test will break.

Another option if we don't want to go this route is for the Core team to create new packages just for this test that we solely control.

@aranke
Copy link
Member Author

aranke commented Jun 4, 2024

Furthermore, because we're using the idempotent release time, we should not run into merge conflicts like this one: dbt-labs/hub.getdbt.com#1484 (comment)

@aranke aranke changed the title add timestamps to entries Use the timestamp of the first file within the GZIP archive for published_at Jun 4, 2024
@aranke aranke changed the title Use the timestamp of the first file within the GZIP archive for published_at Use the timestamp of the first file within the GZIP archive for published_at Jun 4, 2024
@joellabes
Copy link
Contributor

joellabes commented Jun 13, 2024

We've discussed this separately and are closing for now as we found another way to solve the problem this PR was meant to help with!

@joellabes joellabes closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants