Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh_mode and initialize for snowflake dynamic table configuration #5701

Merged
merged 9 commits into from
Jul 19, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Jun 26, 2024

What are you changing in this pull request and why?

We added two new configuration options for the dynamic table materialization in dbt-snowflake: refresh_mode and initialization. These options are specific to dbt-snowflake.
They are available in dbt Cloud and will be introduced in 1.9 in dbt Core.

Checklist

@mikealfare mikealfare self-assigned this Jun 26, 2024
@mikealfare mikealfare requested review from dataders and a team as code owners June 26, 2024 19:49
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 5:10pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jun 26, 2024
@mikealfare
Copy link
Contributor Author

This is failing, but I don't have Vercel access so I can't see why. I'm assuming it's either that I am throwing version blocks in the middle of yaml blocks and tables or that I'm adding a first version of 1.9.

@mikealfare
Copy link
Contributor Author

These are small configuration changes that are specific to a single adapter. Is it worth noting in the migration guide? I notice that's an item in the checklist.

@mirnawong1
Copy link
Contributor

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Jul 12, 2024
@@ -400,6 +421,12 @@ models:
[on_configuration_change](/reference/resource-configs/on_configuration_change): apply | continue | fail
[target_lag](#target-lag): downstream | <time-delta>
[snowflake_warehouse](#configuring-virtual-warehouses): <warehouse-name>
<VersionBlock firstVersion="1.9">

[refresh_mode](#refresh-mode): AUTO | FULL | INCREMENTAL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the version blocks don't work inside of the code blocks. Will change this to a text warning rather than version blocking the whole tab setup

@matthewshaver matthewshaver enabled auto-merge (squash) July 19, 2024 17:01
@matthewshaver matthewshaver merged commit 900512e into current Jul 19, 2024
10 checks passed
@matthewshaver matthewshaver deleted the snowflake-refresh-mode branch July 19, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content external-adapters-team auto labeled issues from the adapter team size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-1076] [Feature] [Dynamic Tables] Add new parameter properties (REFRESH_MODE, INITIALIZE)
4 participants