Remove get_columns
implementation for column metadata generation
#940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #914
Problem
We implemented
redshift-connector
'sget_columns
method for column metadata generation behind a behavior flag. However, it appears there are scenarios whereget_columns
does not find an object whereas the existing custom query does find this object. This is causing failures when this new functionality is turned on. When the functionality is turned off, the user experiences a warning every run.Solution
We have elected to remove the new approach for now as turning it on is not an option and turning it off results in a warning on which the user cannot take action. The new methods and the behavior flag have all been removed. The relevant tests have been skipped so that they may be used again once the source of the discrepancy has been resolved.
Checklist