Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_columns implementation for column metadata generation #940

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Nov 1, 2024

resolves #914

Problem

We implemented redshift-connector's get_columns method for column metadata generation behind a behavior flag. However, it appears there are scenarios where get_columns does not find an object whereas the existing custom query does find this object. This is causing failures when this new functionality is turned on. When the functionality is turned off, the user experiences a warning every run.

Solution

We have elected to remove the new approach for now as turning it on is not an option and turning it off results in a warning on which the user cannot take action. The new methods and the behavior flag have all been removed. The relevant tests have been skipped so that they may be used again once the source of the discrepancy has been resolved.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Nov 1, 2024
@mikealfare mikealfare requested a review from a team as a code owner November 1, 2024 19:01
@cla-bot cla-bot bot added the cla:yes label Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare enabled auto-merge (squash) November 1, 2024 20:28
@mikealfare mikealfare merged commit f50cf7f into main Nov 1, 2024
34 checks passed
@mikealfare mikealfare deleted the remove-get-columns-update branch November 1, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dbt build fails when flag restrict_direct_pg_catalog_access set True
2 participants