Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add doc_blocks to manifest for nodes and columns (#11224)" #11283

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

aranke
Copy link
Member

@aranke aranke commented Feb 7, 2025

This reverts commit d71f309.

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@aranke aranke requested a review from a team as a code owner February 7, 2025 16:53
@cla-bot cla-bot bot added the cla:yes label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (588cbab) to head (02b85cb).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11283   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files         189      189           
  Lines       24161    24138   -23     
=======================================
- Hits        21481    21461   -20     
+ Misses       2680     2677    -3     
Flag Coverage Δ
integration 86.16% <100.00%> (-0.01%) ⬇️
unit 62.56% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.56% <0.00%> (+0.03%) ⬆️
Integration Tests 86.16% <100.00%> (-0.01%) ⬇️

@aranke aranke added Skip Changelog Skips GHA to check for changelog file artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking labels Feb 7, 2025
@aranke aranke merged commit 55e0df1 into main Feb 7, 2025
64 of 69 checks passed
@aranke aranke deleted the revert_11224 branch February 7, 2025 17:12
aranke added a commit that referenced this pull request Feb 11, 2025
aranke added a commit that referenced this pull request Feb 11, 2025
* Reapply "Add `doc_blocks` to manifest for nodes and columns (#11224)" (#11283)

This reverts commit 55e0df1.

* Expand doc_blocks backcompat test

* Refactor to method, add docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants