-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libpitt/enumerate thread #60
base: dev-integrate
Are you sure you want to change the base?
Conversation
…ound5 Leaves add_calculated_fields() unwanted fields on origin_samples[0] d…
src/app.py
Outdated
logger.info('Started live reindex all') | ||
else: | ||
logger.info('Could not start live reindex all. Thread already running.') | ||
return 'Request of live reindex all documents not accepted', 409 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@libpitt I would change the return to add that the method is already running.
"Request of live reindex all documents not accepted. Reindex all process already running" - something like that
@libpitt @maxsibilla have you tested in a docker environment? The search-api runs as a multi-processing and multi-threading mode in the docker deployment. |
Just locally. I will test that now. |
@yuanzhou That seems to be working in a docker environment |
I'm converting this PR to DRAFT for now based on the conversation from Slack. If later we are sure we won't need this feature, this PR can be closed by then.This implementation doesn't work well. I was still able to start the reindex-all process multiple times when the thread didn't exist in one of the workers. In practice, we may have more workers and each worker may have more than 1 threads. A former developer added this We will be working on New reindex-all script feature with dedicated logging in the upcoming sprint. This blog explained Python (we use 3.9 currently) doesn't have true multithreading, yet. The proper support is coming to Python 3.13.
|
Change log:
@maxsibilla Does this look okay to you? My commit:
main...libpitt/enumerate-thread
cc @yuanzhou @shirey