Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Solr 9.8 #478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix compatibility with Solr 9.8 #478

wants to merge 1 commit into from

Conversation

jbaiter
Copy link
Member

@jbaiter jbaiter commented Jan 31, 2025

  • <lib> directives in the core config need to be explicitely enabled (needed for integration tests)
  • IndexSearcher.storedFields() is now used for Lucene versions >= 9.5 instead of the deprecated doc method for retrieving stored field values.
  • Update code formatter
  • Remove OcrHighlighter#getTermVectors(), no longer needed to fulfill the interface

@jbaiter jbaiter requested review from schmika and Copilot January 31, 2025 11:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • integration-tests/run.sh: Language not supported
  • pom.xml: Language not supported
- `<lib>` directives in the core config need to be explicitely enabled
  (needed for integration tests)
- `IndexSearcher.storedFields()` is now used for Lucene versions >= 9.5
  instead of the deprecated `doc` method for retrieving stored field
  values.
- Update code formatter
- Remove `OcrHighlighter#getTermVectors()`, no longer needed to fulfill
  the interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant