Make I/O during indexing generic #438
Merged
+257
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiter
force-pushed
the
indexing-sourcereader
branch
from
d683e1e to
da267c4
Compare
schmika
force-pushed
the
indexing-sourcereader
branch
from
6b505e8 to
120d85a
Compare
schmika
reviewed
Jun 12, 2024
src/main/java/com/github/dbmdz/solrocr/reader/BaseSourceReader.java
Outdated
Show resolved
Hide resolved
schmika
reviewed
Jun 12, 2024
src/main/java/com/github/dbmdz/solrocr/reader/SourceReader.java
Outdated
Show resolved
Hide resolved
jbaiter
changed the title
schmika
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the code to use the same
SourceReadrAPI we use for highlighting during indexing.This should make implementing other storage backends easier, since there's now only one place that I/O has to be implemented instead of two.