Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FlowMessage by TraceableMessage #147

Closed
bitzl opened this issue Apr 2, 2020 · 1 comment
Closed

Replace FlowMessage by TraceableMessage #147

bitzl opened this issue Apr 2, 2020 · 1 comment

Comments

@bitzl
Copy link
Member

bitzl commented Apr 2, 2020

Flusswerk highly encourages the use of custom message implementations. As these were error prone, an abstract base class FlusswerkMessage was introduced, abstracting technical requirements. The idea was to make your implementation as safe and simple as possible without getting in your way.

To support tracing a processing flow there is a Message implementation FlowMessage. This class breaks the spirit in that it is a subclass of DefaultMessage and not an abstract technical base class anymore.

Solution

Deprecate/remove FlowMessage and Introduce TraceableMessage (here assuming #143 - removing id - is already implemented):

public abstract class TraceableMessage extends FlusswerkMessage {

  private final String tracingId;

  public TraceableMessage(String tracingId) {
    this.tracingId = tracingId;
  }

  public String getTracingId() {
    return tracingId;
  }

}
@bitzl
Copy link
Member Author

bitzl commented May 8, 2020

Won't fix: Tracing is now part of Message itself.

@bitzl bitzl closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant