Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HasFlowId and improve propagation logic #148

Closed
bitzl opened this issue Apr 2, 2020 · 0 comments · Fixed by #177
Closed

Remove HasFlowId and improve propagation logic #148

bitzl opened this issue Apr 2, 2020 · 0 comments · Fixed by #177
Labels
breaking Marks a breaking change

Comments

@bitzl
Copy link
Member

bitzl commented Apr 2, 2020

Problem
To trace a processing flow to a workflow graph one has to enable tracing via FlowBuilder.propagateFlowIds(true) and either use FlowMessage or implement the interface ?HasFlowId. This is complicated, as the information if tracing is desired is distributed (flag and interface). There are also multiple ways to use tracing in a message class (use FlowMessageorHasFlowId) with the less recommended approach beeing the most visible one (using FlowMessagemeans for most people just to useDefaultMessage`).

Solution
For tracing

  • check if incoming and outgoing messages implement TraceableMessage
  • check if incoming message has a value for flow id and set that for the outgoing message

Remove old tracing mechanisms:

Questions
Can we have sanity checks if both incoming and outgoing message types are traceable messages on application start?

@bitzl bitzl added the breaking Marks a breaking change label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Marks a breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant