Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic id from Message #143

Closed
bitzl opened this issue Apr 1, 2020 · 1 comment
Closed

Remove generic id from Message #143

bitzl opened this issue Apr 1, 2020 · 1 comment
Labels
breaking Marks a breaking change
Milestone

Comments

@bitzl
Copy link
Member

bitzl commented Apr 1, 2020

The Message interface has a generic type for an identifier attribute. Due to complex nested generics and different possible implementations, this generic type is mostly ommitted. At the same time, the interface's T getId() is never used outside of unit tests.

Applications build upon the framework are strongly encouraged to implement their own message classes and would not rely on the id property. There are applications that won't use the id property at all.

Suggested solution
Is it possible to remove the ID getId() property and the generic type parameter from the Message interface?

Now:

public interface Message<ID> {

  Envelope getEnvelope();

  ID getId();
}

New:

public interface Message {

  Envelope getEnvelope();

}
@bitzl bitzl added the breaking Marks a breaking change label Apr 3, 2020
@bitzl bitzl added this to the Flusswerk 4.0 milestone Apr 3, 2020
@bitzl
Copy link
Member Author

bitzl commented May 8, 2020

Resolved by #165

@bitzl bitzl closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Marks a breaking change
Projects
None yet
Development

No branches or pull requests

1 participant